Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ref to empty response causing an error (Error: test The $ref tarrgets root is not found: #/components/responses/created) #416

Merged
merged 1 commit into from
May 28, 2020

Conversation

alexkar598
Copy link

Since there was no "content" or "$ref", it didnt register as part of the schema which caused it to be unable to find the key. This PR assigns an empty object to the key.

This should of been caught by the test unit but the test unit contained an invalid configuration so it didnt catch anything at all. I fixed that too

Resolves the issue in the comment of #330 (comment) (that comment, not the issue, thats for something else)

…rgets root is not found: #/components/responses/created)
@horiuchi
Copy link
Owner

@alexkar598 Thank you for your contribution!
LGTM

But some unit tests are failed. Please do the command: npm run test:update-snapshot.

@alexkar598
Copy link
Author

alexkar598 commented May 25, 2020

Running the test units on my system resulted in pretty much all of then failing due to line ending errors(I think), I was hoping for CI to run them for me... but travis didnt fire

@horiuchi horiuchi merged commit 27cce85 into horiuchi:master May 28, 2020
@alexkar598 alexkar598 deleted the fix branch October 23, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants