making hive warehouse connector compatible with spark 2.4 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not write the patch, I'm just creating the PR based on #272 |
|
I know this is old but: @carloslima did you test this and did this work for you with Spark 2.4? |
|
@lfrancke old, indeed 😅 We opted to go a different route so I have no feedback to offer :-) Please, note that I didn't write this patch. This is all @abh1sh2k work, the only thing I did was open this MR based on their fork that was mentioned in #272. Assuming @abh1sh2k still uses this patch, they may have something to share :-) |
|
Thanks anyway! I assumed as much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently method like executeQuery does not work when running this library with spark 2.4.0 because in spark 2.4.0 some classes have been removed and some classes have been renamed
DataReaderFactory have been renamed to InputPartition
2)DataReader have been renamed to InputPartitionReader
3)SupportsWriteInternalRow have been removed
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)