-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 404 when comment using mention i.e. @[user] #6166
Comments
@ramyaragupathy working on this issue |
Hey @Aadesh-Baral, when are you planning to look into this issue? Did you find anything yet? |
Hi @royallsilwallz, I've been investigating the issue, and it appears to be related to the frontend. It seems there might be a problem either in our implementation of TributeJS for mentions or in TributeJS itself. Specifically, when a user is mentioned and the Tribute popup is closed, the user search endpoint should not be triggered. Currently, we are making a request to the user search endpoint with every key press in the text area, considering the text after @ as the search query even after the popup is closed. One potential solution could be to use the tribute.isActive flag to check if the Tribute popup is open before making a request to the user search endpoint. However, there seems to be an issue in implementing this approach. The problem lies in the fact that the tribute.isActive flag returns false and then immediately true once the menu is closed. Here's the sequence of events:
The issue might be in how we implemented tributejs or could potentially be a problem in TributeJS itself. However, I couldn't find such issues in the TributeJS repository. |
Hey @Aadesh-Baral, I've made a PR for this issue. Can you verify ? |
Describe the bug
When commenting on comment section during project mapping, validation as well as Question and answer section, mentioning to any user gives error 404.
To Reproduce
Steps to reproduce the behavior:
Screenshots
Additional context
The error doesn't disturb on the workflow i.e. user will be able to perform/submit mapping and validation.
The text was updated successfully, but these errors were encountered: