Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 Network Error in Comments Section #6217

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

royallsilwallz
Copy link
Contributor

@royallsilwallz royallsilwallz commented Jan 23, 2024

@royallsilwallz royallsilwallz changed the title Fix 404 Network Error on Comments Section Fix 404 Network Error in Comments Section Jan 23, 2024
@royallsilwallz royallsilwallz force-pushed the fix/6166-network-error-on-comment-tag branch from acac587 to 6e42c5c Compare January 24, 2024 04:22
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Aadesh-Baral
Copy link
Contributor

@royallsilwallz Still getting the same error.
isValueFromSuggestion is set false once the user clicks the suggestion but it is again set to true if user clicks any other character.
Screenshot 2024-01-29 at 21 22 09

@royallsilwallz royallsilwallz force-pushed the fix/6166-network-error-on-comment-tag branch from 6e42c5c to 117e947 Compare March 18, 2024 14:06
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@royallsilwallz
Copy link
Contributor Author

Hey @Aadesh-Baral, I've pushed the fix. Can you verify? Thanks!

@ramyaragupathy ramyaragupathy added this to the v4.7.1 milestone Mar 21, 2024
@ramyaragupathy
Copy link
Member

Per discussion with team, issues raised by Aadesh has been fixed and verified. So merging it here.

@ramyaragupathy ramyaragupathy merged commit 2aa429c into develop Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 404 when comment using mention i.e. @[user]
3 participants