adding more iphone support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for your repo, amazing & inspiring reverse engineering!
I found some examples of photos taken with iPhone where the current code extracts the wrong meta image as depth. I did some digging and found out sometimes the newer iPhones are saving all sorts of masks also hidden in the meta data. Here are some examples where it doesnt work and I included one image that does work. https://drive.google.com/drive/folders/1HhuuN2Nsn30yCKhCOqA4_JSL5avLF0Fo?usp=sharing You can see in the filenames which ones work and which ones dont. I found that you can still condition on the order of the meta images. So if there are more than 6 hidden meta photos then it is most likely the one in the 4th position. This was found out on a case by case basis, so there still may be photos out there that are not accounted for. Apple doesnt have any externally facing documentation on where the depth photos are stored since they want us to use their libraries. I tested it that it still works 100% for all of the iphone photos that it worked for before. (because it returns if there are still only 3 photos)
Anyways, hopefully this addition can help! Let me know if I should make any other changes or if you have any questions.
All the best,
Char