Помощь друга #10
Open
Помощь друга #10
+132
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
236
to
+238
| <script type="module" src="./js/main.js"></script> | ||
| <script src="./vendor/pristine/pristine.min.js"></script> | ||
| <script src="./vendor/nouislider/nouislider.js"></script> |
There was a problem hiding this comment.
<script src="./vendor/pristine/pristine.min.js"></script>
<script src="./vendor/nouislider/nouislider.js"></script>
<script type="module" src="./js/main.js"></script>
Тут нужно поправить порядок подключения скриптов. Сначала правильнее подключать библиотеки, а после уже свои скрипты
Comment on lines
+17
to
+94
| sliderEffect.noUiSlider.on('update', () => { | ||
| valueEffect.value = sliderEffect.noUiSlider.get(); | ||
| }); | ||
| effectLevel.classList.add('hidden'); | ||
|
|
||
| function onEffectListChange (evt) { | ||
| const effect = evt.target.value; | ||
| if (effect === 'none') { | ||
| effectLevel.classList.add('hidden'); | ||
| previewPhoto.removeAttribute('style'); | ||
| } else if (effect === 'chrome') { | ||
| effectLevel.classList.remove('hidden'); | ||
| sliderEffect.noUiSlider.updateOptions({ | ||
| range: { | ||
| min: 0, | ||
| max: 1, | ||
| }, | ||
| start: 1, | ||
| step: 0.1, | ||
| }); | ||
| valueEffect.value = sliderEffect.noUiSlider.get(); | ||
| sliderEffect.noUiSlider.on('update', () => { | ||
| previewPhoto.style.filter = `grayscale(${valueEffect.value})`; | ||
| }); | ||
| } else if (effect === 'sepia') { | ||
| effectLevel.classList.remove('hidden'); | ||
| sliderEffect.noUiSlider.updateOptions({ | ||
| range: { | ||
| min: 0, | ||
| max: 1, | ||
| }, | ||
| start: 1, | ||
| step: 0.1, | ||
| }); | ||
| sliderEffect.noUiSlider.on('update', () => { | ||
| previewPhoto.style.filter = `sepia(${valueEffect.value})`; | ||
| }); | ||
| } else if (effect === 'marvin') { | ||
| effectLevel.classList.remove('hidden'); | ||
| sliderEffect.noUiSlider.updateOptions({ | ||
| range: { | ||
| min: 0, | ||
| max: 100, | ||
| }, | ||
| start: 100, | ||
| step: 1, | ||
| }); | ||
| sliderEffect.noUiSlider.on('update', () => { | ||
| previewPhoto.style.filter = `invert(${valueEffect.value}%)`; | ||
| }); | ||
| } else if (effect === 'phobos') { | ||
| effectLevel.classList.remove('hidden'); | ||
| sliderEffect.noUiSlider.updateOptions({ | ||
| range: { | ||
| min: 0, | ||
| max: 3, | ||
| }, | ||
| start: 3, | ||
| step: 0.1, | ||
| }); | ||
| sliderEffect.noUiSlider.on('update', () => { | ||
| previewPhoto.style.filter = `blur(${valueEffect.value}px)`; | ||
| }); | ||
| } else if (effect === 'heat') { | ||
| effectLevel.classList.remove('hidden'); | ||
| sliderEffect.noUiSlider.updateOptions({ | ||
| range: { | ||
| min: 1, | ||
| max: 3, | ||
| }, | ||
| start: 3, | ||
| step: 0.1, | ||
| }); | ||
| sliderEffect.noUiSlider.on('update', () => { | ||
| previewPhoto.style.filter = `brightness(${valueEffect.value})`; | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Модуль с фильтрами можно значительно улучшить. Такие задачки обычно решаются с описанием конфигурации фильтров.
Наподобии такого, можно заиспользовать у себя
const EFFECT_SETTINGS = {
none: {
hidden: true,
filter: null,
},
chrome: {
range: { min: 0, max: 1 },
start: 1,
step: 0.1,
filter: (value) => `grayscale(${value})`
},
sepia: {
range: { min: 0, max: 1 },
start: 1,
step: 0.1,
filter: (value) => `sepia(${value})`
},
marvin: {
range: { min: 0, max: 100 },
start: 100,
step: 1,
filter: (value) => `invert(${value}%)`
},
phobos: {
range: { min: 0, max: 3 },
start: 3,
step: 0.1,
filter: (value) => `blur(${value}px)`
},
heat: {
range: { min: 1, max: 3 },
start: 3,
step: 0.1,
filter: (value) => `brightness(${value})`
}
};
Такую структуру очень легко расширять.
Из объекта можно считывать выбранный фильтров const effect = evt.target.value; дабы избежать if-else и применять уже к нему обвязку
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Помощь друга