Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Python 3.12 pip/setuptools changes #108

Closed

Conversation

joshuahaddad
Copy link

@joshuahaddad joshuahaddad commented Apr 18, 2024

Purpose

The purpose of this pull request is to update dependencies such that the package can be installed on python 3.12. With the changes in setuptools introduced py3.12 cannot build wheels for some earlier packages. The changes in this PR address this issue as well as add a slight modification to the TSNE object in optics_dbscan_pairs_clustering.py since it uses a deprecated default argument. The argument (init="random") is explicitly provided instead of using the default parameter as this breaks the tests on newer versions of sklearn (init="pca" and current tests run into similar issues as described here)

Approach

Packages were updated to versions usable in py3.12. Tests were run to insure no breaking changes occurred. Packages were bounded.

Import of keras model backend was updated to documented import path.

TSNE parameter explicitly defined to address deprecation of default init parameter.

Tests for New Behavior

Pytest was run and deficiencies were addressed such that the test suite passes. The tests were run in fresh virtual environments for Python 3.12 and 3.8.

Checklist

Make sure you did the following (if applicable):

  • Added tests for any new features or behaviors.

  • Ran ./pylint to make sure code style is consistent.
    Pylint was run but changes are from original main branch. Should address this (such as imports) in other prs

  • Built and reviewed the docs.

  • Added a note to the changelog.

Learning

@joshuahaddad joshuahaddad changed the title Support/py3.12 Adding support for Python 3.12 pip/setuptools changes Apr 18, 2024
@joshuahaddad joshuahaddad changed the base branch from master to develop April 19, 2024 00:57
@Jackal08
Copy link
Member

Hi @joshuahaddad,

Thanks for this contribution. I am running a bit behind. Please hang in there and I will review this PR.

@joshuahaddad
Copy link
Author

Hi @joshuahaddad,

Thanks for this contribution. I am running a bit behind. Please hang in there and I will review this PR.

Hey Jacques,

Thanks for the response! I think this PR and #98 are redundant given the changes in #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants