-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazing Fast SetFit Inference with 🤗 Optimum Intel on Xeon #1814
Conversation
Co-authored-by: Daniel Korat <[email protected]>
…/blog into setfit-optimum-intel
Note for reviewers: The blogpost is still being edited in a Google Docs environment outside of this PR, so expect fairly notable changes to be merged into this PR later. |
Co-authored-by: Daniel Korat <[email protected]>
Co-authored-by: Daniel Korat <[email protected]>
Co-authored-by: Daniel Korat <[email protected]>
Co-authored-by: Daniel Korat <[email protected]>
Nice one! Co-authored-by: Daniel Korat <[email protected]>
Co-authored-by: Daniel Korat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
These all look very sensible! Co-authored-by: Ella Charlaix <[email protected]>
Thanks for the review @echarlaix! Your suggestions look very sensible. @danielkorat @orenpereg @MosheWasserb What is your ideal release date? |
Hi @tomaarsen, we are just waiting for Intel approval to publish performance numbers on Intel CPU. hope to get it in the next few days. |
All good! Thanks for the heads up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomaarsen
Please replace with this updated version:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielkorat, Do we want to draw the arrow from 119 to 935 to show the 7.8x speedup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aprabhak2 The arrow was initially diagonal, from 119.6 to 935.2, but we got a comment from Gadi saying that a vertical arrow will look better in publication.
WDYT @orenpereg ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to stay with the the vertical arrow. the idea is the the green line in general provides speedup over the blue line. Maybe just change "throughput speedup" to "max throughput speedup 7.8x"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via fbc92fc, feel free to comment again if you prefer another figure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielkorat, Do we want to draw the arrow from 119 to 935 to show the 7.8x speedup?
They look good to me Co-authored-by: Daniel Korat <[email protected]>
Hello!
Pull Request overview
Details
This blogpost follows the notebook contributed by Intel showcasing the performance optimizations possible for SetFit models using optimum-intel.
TODOs:
@echarlaix Feel free to assist me with reviewing.
cc @danielkorat @MosheWasserb @orenpereg