Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazing Fast SetFit Inference with 🤗 Optimum Intel on Xeon #1814

Merged
merged 27 commits into from
Apr 3, 2024

Conversation

tomaarsen
Copy link
Member

@tomaarsen tomaarsen commented Feb 14, 2024

Hello!

Pull Request overview

  • Add "Blazing Fast SetFit Inference on Intel Xeon" blogpost

Details

This blogpost follows the notebook contributed by Intel showcasing the performance optimizations possible for SetFit models using optimum-intel.

TODOs:

@echarlaix Feel free to assist me with reviewing.
cc @danielkorat @MosheWasserb @orenpereg

  • Tom Aarsen

@tomaarsen
Copy link
Member Author

Note for reviewers: The blogpost is still being edited in a Google Docs environment outside of this PR, so expect fairly notable changes to be merged into this PR later.

tomaarsen and others added 2 commits February 14, 2024 13:00
Co-authored-by: Daniel Korat <[email protected]>
Co-authored-by: Daniel Korat <[email protected]>
@tomaarsen tomaarsen changed the title SetFit + Optimum Intel: Blazing Fast SetFit Inference on Intel Xeon Blazing Fast SetFit Inference with 🤗 Optimum Intel on Xeon Feb 14, 2024
Copy link
Contributor

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

These all look very sensible!

Co-authored-by: Ella Charlaix <[email protected]>
@tomaarsen
Copy link
Member Author

Thanks for the review @echarlaix! Your suggestions look very sensible.

@danielkorat @orenpereg @MosheWasserb What is your ideal release date?

@orenpereg
Copy link
Contributor

Hi @tomaarsen, we are just waiting for Intel approval to publish performance numbers on Intel CPU. hope to get it in the next few days.

@tomaarsen
Copy link
Member Author

All good! Thanks for the heads up.

Copy link
Contributor

@danielkorat danielkorat Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomaarsen
Please replace with this updated version:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throughput_vs_batch_size-final

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielkorat, Do we want to draw the arrow from 119 to 935 to show the 7.8x speedup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aprabhak2 The arrow was initially diagonal, from 119.6 to 935.2, but we got a comment from Gadi saying that a vertical arrow will look better in publication.
WDYT @orenpereg ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to stay with the the vertical arrow. the idea is the the green line in general provides speedup over the blue line. Maybe just change "throughput speedup" to "max throughput speedup 7.8x"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via fbc92fc, feel free to comment again if you prefer another figure.

Copy link

@aprabhak2 aprabhak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielkorat, Do we want to draw the arrow from 119 to 935 to show the 7.8x speedup?

@tomaarsen tomaarsen merged commit 5e76191 into main Apr 3, 2024
@tomaarsen tomaarsen deleted the setfit-optimum-intel branch April 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants