-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add peft merging blog post. #1816
Conversation
Hi @sayakpaul and @pacman100, thank you for writing this blog post. I skimmed over it and left a few comments in general looks good to me. |
Co-authored-by: Sourab Mangrulkar <[email protected]>
Co-authored-by: Yu Le <[email protected]>
Hi @sayakpaul and @pacman100, thanks for this excellent blog post. I have completed the proofreading and left several comments on my understanding. Hope this will help. ^_^ Please let me know when you want to post this blog, and I will be glad to share it with other people as well. |
Co-authored-by: Yu Le <[email protected]>
Hello, we are planning on communicating about this on Monday US morning time. |
Thank you @prateeky2806 and @yule-BUAA for the valuable feedback and suggestions! ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the PR for merging! Thank you @sayakpaul for the great initiative and all the work! 🤗
Thank you. Kudos to you for leading the integration! Merging since it's been already proof-read by @prateeky2806 and @yule-BUAA! |
Following huggingface/peft#1364.
Joint work with @pacman100.
Cc: @prateeky2806 @yule-BUAA in case you want to proof-read and review :-)