Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add peft merging blog post. #1816

Merged
merged 24 commits into from
Feb 19, 2024
Merged

add peft merging blog post. #1816

merged 24 commits into from
Feb 19, 2024

Conversation

sayakpaul
Copy link
Member

Following huggingface/peft#1364.

Joint work with @pacman100.

Cc: @prateeky2806 @yule-BUAA in case you want to proof-read and review :-)

@sayakpaul sayakpaul requested a review from pcuenca February 16, 2024 05:49
@prateeky2806
Copy link

prateeky2806 commented Feb 16, 2024

Hi @sayakpaul and @pacman100, thank you for writing this blog post. I skimmed over it and left a few comments in general looks good to me.
Let me know when you plan to announce this on Twitter/HF discord, I will share it with people in my circle.

@yule-BUAA
Copy link
Contributor

Hi @sayakpaul and @pacman100, thanks for this excellent blog post. I have completed the proofreading and left several comments on my understanding. Hope this will help. ^_^

Please let me know when you want to post this blog, and I will be glad to share it with other people as well.

@pacman100
Copy link
Contributor

Hello, we are planning on communicating about this on Monday US morning time.

@pacman100
Copy link
Contributor

Thank you @prateeky2806 and @yule-BUAA for the valuable feedback and suggestions! ✨

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR for merging! Thank you @sayakpaul for the great initiative and all the work! 🤗

@sayakpaul
Copy link
Member Author

Thank you. Kudos to you for leading the integration!

Merging since it's been already proof-read by @prateeky2806 and @yule-BUAA!

@sayakpaul sayakpaul merged commit 8d640fc into main Feb 19, 2024
1 check passed
@sayakpaul sayakpaul deleted the merging-peft branch February 19, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants