Skip to content

Remove aiohttp from direct dependencies #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 18, 2024

The dependency is only used for catching an exception from other code. That can be done with an import guard.

akx and others added 2 commits November 18, 2024 15:58
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ! I moved it to optional dependencies

@lhoestq lhoestq merged commit a6461e9 into huggingface:main May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants