Skip to content

[tests] fix import. #11434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

[tests] fix import. #11434

merged 1 commit into from
Apr 28, 2025

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Not really sure how it was passed.

@sayakpaul
Copy link
Member Author

Should be a simple import change. Merging.

@sayakpaul sayakpaul merged commit 0e3f271 into main Apr 28, 2025
28 of 29 checks passed
@sayakpaul sayakpaul deleted the import-fix branch April 28, 2025 05:32
@yao-matrix
Copy link
Contributor

yao-matrix commented Apr 28, 2025

@sayakpaul the reason is:
In PR #11085, new TorchCompileTesterMixin cases were added w/ require_torch_gpu not not merged.
Later PR #11406 was submitted to enable all gpu only cases to work on XPU, so using require_torch_accelerator and remove require_torch_gpu per ruff since it's not referenced anymore.

But there is a time gap btw these 2 cases merging(2 hours) and it's no conflict btw these PRs, since the later PR didn't change TorchCompileTesterMixin(even not aware of it), and static diff tool cannot detect such situation, since it's a runtime dependency loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants