Skip to content

[ci] enable hotswapping tests on our nightly CI. #11826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sayakpaul
Copy link
Member

What does this PR do?

LoRA hotswapping with compilation is a crucial feature which deserves (at least nightly) testing. This PR enables that.

This PR also sets the RUN_SLOW flag in push_tests.yml for the compilation test job as without it, those tests won't run. Should we enable hotswapping tests in that workflow, too? I am okay if not.

Additionally, a few questions:

  • We have both push_tests_fast.yml and push_tests.yml. I am assuming the tests under push_tests_fast.yml would have already run before the changes made their way to main. So, I wonder if we should remove push_tests_fast.yml?
  • Should we allow slow tests to run during push_tests? We should most definitely look into how we segregate slow and nightly our tests for this.

I believe this deserves attention as it would help us reduce our CI time.

@sayakpaul sayakpaul requested a review from DN6 June 28, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant