[ci] enable hotswapping tests on our nightly CI. #11826
Open
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LoRA hotswapping with compilation is a crucial feature which deserves (at least nightly) testing. This PR enables that.
This PR also sets the
RUN_SLOWflag inpush_tests.ymlfor the compilation test job as without it, those tests won't run. Should we enable hotswapping tests in that workflow, too? I am okay if not.Additionally, a few questions:
push_tests_fast.ymlandpush_tests.yml. I am assuming the tests underpush_tests_fast.ymlwould have already run before the changes made their way tomain. So, I wonder if we should removepush_tests_fast.yml?push_tests? We should most definitely look into how we segregate slow and nightly our tests for this.I believe this deserves attention as it would help us reduce our CI time.