-
Notifications
You must be signed in to change notification settings - Fork 397
[hub] Export HUB_URL constant for consumers #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: julien-c <[email protected]>
Co-authored-by: julien-c <[email protected]>
HUB_URL
so consumers can consume it
BIG SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to package-lock.json
Otherwise, kittens might die.
Co-authored-by: julien-c <[email protected]>
I've removed the package-lock.json file as requested in commit 08a3af2. The repository now only contains the necessary changes for exporting the HUB_URL constant. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also revert the changes to hub/README.md, we don't really care
so smooth |
i don't see a strong difference with humans so far |
@julien-c Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
lmao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, nvm, it's good enough, thanks Copilot, now passing to @coyotte508 for final review
@julien-c Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Co-authored-by: julien-c <[email protected]>
I've reverted the changes to hub/README.md as requested in commit 2d198cd. The HUB_URL export in index.ts remains intact as that's the core functionality of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, perfect, thanks
This PR exports the
HUB_URL
constant from the hub package so that consumers can directly access it in their applications.Changes
export { HUB_URL } from "./consts";
topackages/hub/src/index.ts
Usage Example
This is useful for applications that need to reference the default hub URL or construct hub-related URLs in their code, without having to define the constant themselves.
Fixes #1336.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
hg.mozilla.org
node ./dist/install.js
(dns block)hub-ci.huggingface.co
node /home/REDACTED/work/huggingface.js/huggingface.js/node_modules/.bin/../vitest/vitest.mjs run
(dns block)huggingface.co
node /home/REDACTED/work/huggingface.js/huggingface.js/node_modules/.bin/../vitest/vitest.mjs run
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.