feat: Adds a new environment variable HF_HUB_USER_AGENT_ORIGIN to set origin of calls in user-agent #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agent. This can be used to track calls for partners for collaborations.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
reviewed
Feb 17, 2025
| @@ -125,6 +125,16 @@ def build_hf_headers( | |||
| # Get auth token to send | |||
| token_to_send = get_token_to_send(token) | |||
|
|
|||
| # Retrieve user-agent origin headers from environment variable | |||
| origin = constants.HF_HUB_USER_AGENT_ORIGIN | |||
There was a problem hiding this comment.
To avoid the if isinstance(...): ... elif: ... else: ... logic I would move this logic inside _http_user_agent directly.
Wauplin
reviewed
Feb 17, 2025
There was a problem hiding this comment.
As mentioned on slack (private link) I'm fine with this solution. Feel free to ping me and @hanouticelina once you've agreed on the convention internally and we should be able to merge quite quickly.
Wauplin
approved these changes
Feb 17, 2025
hanouticelina
approved these changes
Feb 17, 2025
|
Good to merge for me @Wauplin @hanouticelina if you are 👍 |
|
@Hugoch all good on my side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
HF_HUB_USER_AGENT_ORIGINenvironment variable that allows to set an origin to HTTP headers. It is convenient to track requests made by partners during collaborations.