Skip to content

Added fallback for incomplete configs for vlm models launched as llms #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

Added fallback for incomplete configs for vlm models launched as llms #828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8572854
added fallback for incomplete configs for vlm models launched as llms
clefourrier Jun 24, 2025
025c3f6
Merge branch 'main' into clem_config_fallback
clefourrier Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/lighteval/models/transformers/transformers_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,13 +456,16 @@ def _init_max_length(self) -> int:
return self.config.max_length

# Try to get the sequence length from the model config.
text_model_config = self.transformers_config.get_text_config()

seqlen_config_attrs = ("n_positions", "max_position_embeddings", "n_ctx")
for attr in seqlen_config_attrs:
if hasattr(self.transformers_config, attr):
return getattr(self.transformers_config, attr)
if hasattr(text_model_config, attr):
return getattr(text_model_config, attr)

logger.warning(
"No max_length attribute found in the model config. Using the default max sequence length setting {2048}. It is recomended to set max_length through the model args"
"No max_length attribute found in the model config. Using the default max sequence length setting `2048`. "
"It is recommended to set max_length trough the model args: max_length=..."
)

return 2048
Expand Down
Loading