Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotswap allow different alpha scalings and ranks #2177

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

BenjaminBossan
Copy link
Member

@BenjaminBossan BenjaminBossan commented Oct 24, 2024

WIP

See huggingface/diffusers#9453 for context.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@BenjaminBossan
Copy link
Member Author

not stale

@BenjaminBossan BenjaminBossan changed the title Hotswap allow different alpha scalings Hotswap allow different alpha scalings and ranks Dec 11, 2024
@BenjaminBossan
Copy link
Member Author

@sayakpaul I had some time to brush up this PR. How do we proceed? As you can see, I have added diffusers tests, but since huggingface/diffusers#9453 is not merged, it won't work yet (i.e. there are recompiles). That PR is awaiting this PR, so there is a mutual dependency.

Also, for now Conv2d is not fully implemented, but to confirm that it works, we could test with only Linear, right?

@sayakpaul
Copy link
Member

Also, for now Conv2d is not fully implemented, but to confirm that it works, we could test with only Linear, right?

That should work for now. I would add a note about this somewhere.

@sayakpaul I had some time to brush up this PR. How do we proceed? As you can see, I have added diffusers tests, but since huggingface/diffusers#9453 is not merged, it won't work yet (i.e. there are recompiles).

To make progress and help unblock this PR, how about we merge this PR with sufficient testing (which I believe we already have) and mark the diffusers test with an xfail?

@BenjaminBossan BenjaminBossan marked this pull request as ready for review January 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants