-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotswap allow different alpha scalings and ranks #2177
base: main
Are you sure you want to change the base?
Hotswap allow different alpha scalings and ranks #2177
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
not stale |
Smaller to larger rank works, larger to smaller still fails.
Differing alphas is no longer cause to raise an error.
@sayakpaul I had some time to brush up this PR. How do we proceed? As you can see, I have added diffusers tests, but since huggingface/diffusers#9453 is not merged, it won't work yet (i.e. there are recompiles). That PR is awaiting this PR, so there is a mutual dependency. Also, for now |
That should work for now. I would add a note about this somewhere.
To make progress and help unblock this PR, how about we merge this PR with sufficient testing (which I believe we already have) and mark the |
WIP
See huggingface/diffusers#9453 for context.