align xpu behavior w/ cuda #2551
Conversation
Signed-off-by: Matrix Yao <[email protected]>
Signed-off-by: YAO Matrix <[email protected]>
|
@githubnemo , pls help review, thx very much. |
|
@IlyasMoutawwakil , could you pls help review? Thx |
|
@IlyasMoutawwakil , do you know who can help review and merge the PR for peft repo? Thx very much. |
Signed-off-by: YAO Matrix <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
2. refine skip message Signed-off-by: Matrix YAO <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
yao-matrix
changed the title
| @@ -78,7 +78,7 @@ def require_torch_multi_gpu(test_case): | |||
| return test_case | |||
|
|
|||
|
|
|||
| def require_multi_accelerator(test_case): | |||
| def require_torch_multi_accelerator(test_case): | |||
There was a problem hiding this comment.
this is actually for torch multi-accelerator, since it uses torch_device, change the name to reflect the fact and align the name convention w/ require_torch_multi_gpu.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
I agree with @IlyasMoutawwakil, it would be best to use a helper function to determine if bfloat16 is available.
LGTM otherwise :)
Signed-off-by: Matrix YAO <[email protected]>
Signed-off-by: Matrix YAO <[email protected]>
|
@IlyasMoutawwakil @githubnemo i've updated the PR per your comments, pls help review and comment. and i've checked the ci failure, seems not related to my changes, thx very much. |
lorafaandrandlora: i can see peft requirementtorch >=1.13, and in 1.13,torchalready has a device agnostictorch.autocast, switch to use the device agnostic API to also cover xputorch.cuda.xx; after this PR, all use device-agnostic clean cache APIgptqmodelmulti-device test case on XPU, enabletorchaotest cases on XPU