make method comparison device agnostic, so it can expand to more accelerators like XPU #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accelerators like XPU Signed-off-by: YAO Matrix <[email protected]>
There was a problem hiding this comment.
Generally, the PR LGTM. I tested running an experiment, the logs look correct and the app is working as expected. I wonder if we can find better names than "accelerator_memory_reserved_avg", as "accelerator" is quite a mouthful, but I can live with it.
@yao-matrix can you confirm that the script runs successfully on XPU? Could you perhaps run a LoRA experiment and share the result log in a comment?
method_comparison/app.py
Outdated
| @@ -222,7 +222,7 @@ def build_app(df): | |||
|
|
|||
| with gr.Row(): | |||
| x_default = ( | |||
| "cuda_memory_max" if "cuda_memory_max" in metric_preferences else list(metric_preferences.keys())[0] | |||
| "accelerator_memory_max" if "accelerator_memory_max" in metric_preferences else list(metric_preferences.keys())[0] | |||
There was a problem hiding this comment.
Could you please add line breaks (or run ruff format app.py)?
There was a problem hiding this comment.
done with ruff format, thx.
Signed-off-by: YAO Matrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BenjaminBossan @githubnemo , #2606 corrupted while rebasing, so I opened another PR here. Pls help review, thx very much.