Skip to content

Added model name label to metrics and added an optional argument --served-model-name #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added model name label to metrics and added an optional argument --served-model-name #3064

wants to merge 1 commit into from

Conversation

yashaswipiplani
Copy link

What does this PR do?

Fixes:

  1. model_name label is absent in metrics. Fixed this by adding the label in all the LLM metrics.
  2. Added an optional argument served-model-name. If provided, model_name label is served_model_name, else defaulted to model_id

Issue link: #3026

@yashaswipiplani yashaswipiplani changed the base branch from main to git_v2.4.1 February 27, 2025 19:27
@yashaswipiplani yashaswipiplani changed the base branch from git_v2.4.1 to main February 27, 2025 19:27
@Narsil Narsil added the wontfix This will not be worked on label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashaswipiplani @Narsil