Skip to content

feat: improve llava next pooling for granite vision #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: improve llava next pooling for granite vision #3255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30bdf92
feat: improve llava next pooling for granite vision
drbh Jun 4, 2025
2204f91
fix: adjust llava logic and bump snaps
drbh Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 40 additions & 40 deletions integration-tests/models/__snapshots__/test_llava_next/test_flash_llava_next_load.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,61 +9,61 @@
"tokens": [
{
"id": 13,
"logprob": -0.007621765,
"logprob": -0.052612305,
"special": false,
"text": "\n"
},
{
"id": 13,
"logprob": -0.20812988,
"logprob": -0.079589844,
"special": false,
"text": "\n"
},
{
"id": 16114,
"logprob": -1.2587891,
"logprob": -1.6865234,
"special": false,
"text": "Once"
},
{
"id": 3714,
"logprob": -0.20825195,
"logprob": -0.20983887,
"special": false,
"text": " upon"
},
{
"id": 264,
"logprob": -0.0017709732,
"logprob": -0.0014019012,
"special": false,
"text": " a"
},
{
"id": 727,
"logprob": -0.011932373,
"logprob": -0.0121154785,
"special": false,
"text": " time"
},
{
"id": 28725,
"logprob": -0.17297363,
"logprob": -0.15405273,
"special": false,
"text": ","
},
{
"id": 736,
"logprob": -0.9057617,
"logprob": -0.4802246,
"special": false,
"text": " there"
},
{
"id": 403,
"logprob": -0.05758667,
"logprob": -0.03289795,
"special": false,
"text": " was"
},
{
"id": 264,
"logprob": -0.00970459,
"logprob": -0.01423645,
"special": false,
"text": " a"
}
Expand All @@ -82,61 +82,61 @@
"tokens": [
{
"id": 13,
"logprob": -0.007621765,
"logprob": -0.052612305,
"special": false,
"text": "\n"
},
{
"id": 13,
"logprob": -0.20275879,
"logprob": -0.07946777,
"special": false,
"text": "\n"
},
{
"id": 16114,
"logprob": -1.2578125,
"logprob": -1.6914062,
"special": false,
"text": "Once"
},
{
"id": 3714,
"logprob": -0.2084961,
"logprob": -0.21020508,
"special": false,
"text": " upon"
},
{
"id": 264,
"logprob": -0.0017738342,
"logprob": -0.0014238358,
"special": false,
"text": " a"
},
{
"id": 727,
"logprob": -0.011932373,
"logprob": -0.012138367,
"special": false,
"text": " time"
},
{
"id": 28725,
"logprob": -0.17297363,
"logprob": -0.15625,
"special": false,
"text": ","
},
{
"id": 736,
"logprob": -0.9057617,
"logprob": -0.47827148,
"special": false,
"text": " there"
},
{
"id": 403,
"logprob": -0.05758667,
"logprob": -0.03289795,
"special": false,
"text": " was"
},
{
"id": 264,
"logprob": -0.00970459,
"logprob": -0.01423645,
"special": false,
"text": " a"
}
Expand All @@ -155,61 +155,61 @@
"tokens": [
{
"id": 13,
"logprob": -0.007621765,
"logprob": -0.052246094,
"special": false,
"text": "\n"
},
{
"id": 13,
"logprob": -0.20275879,
"logprob": -0.07739258,
"special": false,
"text": "\n"
},
{
"id": 16114,
"logprob": -1.2578125,
"logprob": -1.6875,
"special": false,
"text": "Once"
},
{
"id": 3714,
"logprob": -0.2084961,
"logprob": -0.20922852,
"special": false,
"text": " upon"
},
{
"id": 264,
"logprob": -0.0017738342,
"logprob": -0.0014228821,
"special": false,
"text": " a"
},
{
"id": 727,
"logprob": -0.011932373,
"logprob": -0.012130737,
"special": false,
"text": " time"
},
{
"id": 28725,
"logprob": -0.17297363,
"logprob": -0.15612793,
"special": false,
"text": ","
},
{
"id": 736,
"logprob": -0.9057617,
"logprob": -0.47827148,
"special": false,
"text": " there"
},
{
"id": 403,
"logprob": -0.05758667,
"logprob": -0.032928467,
"special": false,
"text": " was"
},
{
"id": 264,
"logprob": -0.00970459,
"logprob": -0.014144897,
"special": false,
"text": " a"
}
Expand All @@ -228,61 +228,61 @@
"tokens": [
{
"id": 13,
"logprob": -0.007621765,
"logprob": -0.052978516,
"special": false,
"text": "\n"
},
{
"id": 13,
"logprob": -0.20812988,
"logprob": -0.080444336,
"special": false,
"text": "\n"
},
{
"id": 16114,
"logprob": -1.2587891,
"logprob": -1.6826172,
"special": false,
"text": "Once"
},
{
"id": 3714,
"logprob": -0.20825195,
"logprob": -0.21044922,
"special": false,
"text": " upon"
},
{
"id": 264,
"logprob": -0.0017709732,
"logprob": -0.0014238358,
"special": false,
"text": " a"
},
{
"id": 727,
"logprob": -0.011932373,
"logprob": -0.012107849,
"special": false,
"text": " time"
},
{
"id": 28725,
"logprob": -0.17297363,
"logprob": -0.15405273,
"special": false,
"text": ","
},
{
"id": 736,
"logprob": -0.9057617,
"logprob": -0.47875977,
"special": false,
"text": " there"
},
{
"id": 403,
"logprob": -0.05758667,
"logprob": -0.03289795,
"special": false,
"text": " was"
},
{
"id": 264,
"logprob": -0.00970459,
"logprob": -0.01423645,
"special": false,
"text": " a"
}
Expand Down
20 changes: 10 additions & 10 deletions integration-tests/models/__snapshots__/test_llava_next/test_flash_llava_next_simple.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,61 +8,61 @@
"tokens": [
{
"id": 13,
"logprob": -0.00756073,
"logprob": -0.052612305,
"special": false,
"text": "\n"
},
{
"id": 13,
"logprob": -0.20117188,
"logprob": -0.07739258,
"special": false,
"text": "\n"
},
{
"id": 16114,
"logprob": -1.2597656,
"logprob": -1.6914062,
"special": false,
"text": "Once"
},
{
"id": 3714,
"logprob": -0.20825195,
"logprob": -0.21020508,
"special": false,
"text": " upon"
},
{
"id": 264,
"logprob": -0.00178051,
"logprob": -0.0014228821,
"special": false,
"text": " a"
},
{
"id": 727,
"logprob": -0.011955261,
"logprob": -0.012123108,
"special": false,
"text": " time"
},
{
"id": 28725,
"logprob": -0.17541504,
"logprob": -0.15625,
"special": false,
"text": ","
},
{
"id": 736,
"logprob": -0.91308594,
"logprob": -0.47875977,
"special": false,
"text": " there"
},
{
"id": 403,
"logprob": -0.058410645,
"logprob": -0.033416748,
"special": false,
"text": " was"
},
{
"id": 264,
"logprob": -0.009689331,
"logprob": -0.014137268,
"special": false,
"text": " a"
}
Expand Down
Loading
Loading