[CI] Test ARM64 build with GithubActions #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hugsy <[email protected]>
Signed-off-by: hugsy <[email protected]>
1 similar comment
Signed-off-by: hugsy <[email protected]>
hugsy
requested review from
Grazfather,
daniellimws,
therealdreg,
ValekoZ and
theguy147
Signed-off-by: hugsy <[email protected]>
1 similar comment
Grazfather
reviewed
Mar 15, 2025
| @@ -292,6 +294,7 @@ def setUp(self) -> None: | |||
| self.expected_tcache_bin_size = 0x20 if ARCH == "i686" or is_64b() else 0x18 | |||
| return super().setUp() | |||
|
|
|||
| @pytest.mark.skipif(ARCH not in ("i686", "x86_64"), reason=f"Skipped for {ARCH}") | |||
There was a problem hiding this comment.
Is this still arch specific? Do you have an arm machine to test on? would be nice if it at least passed locally.
I am setting up a raspberry pi in the next few days for something related, I should be able to test if you can wait.
There was a problem hiding this comment.
No problem, it can wait but I'm happy to re-test on my devices too
Signed-off-by: hugsy <[email protected]>
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ubuntu ARM runners are now available. Add them to the test suite.
Note: the following tests are marked as skipped for
aarch64since they failed on CI (but work locally). Will revisit latertest_func_parse_maps_remote_qemutest_func_parse_maps_realpathtest_cmd_heap_bins_tcachetest_cmd_heap_bins_tcache_alltest_can_establish_connection_to_gdbserver_again_after_disconnectChecklist