Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LibraryChart #7596

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Remove LibraryChart #7596

merged 1 commit into from
Jan 17, 2025

Conversation

Zasa-san
Copy link
Collaborator

@Zasa-san Zasa-san commented Jan 17, 2025 •
edited
Loading

Removes:

  • app/react/Charts/components/LibraryChart.js
  • app/react/Charts/components/LibraryCharts.js
    which seem to be unused.

Removes the tag exclusion from app/react/Markdown/utils.js since they are not valid html or markdown components.

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@Zasa-san Zasa-san marked this pull request as ready for review January 17, 2025 15:54
@Zasa-san Zasa-san merged commit 8281897 into development Jan 17, 2025
17 of 18 checks passed
@Zasa-san Zasa-san deleted the remove-LibraryCharts branch January 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zasa-san