Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judge: fix submission dispose too early & make submit_answer more efficient #962

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

criyle
Copy link
Contributor

@criyle criyle commented Mar 14, 2025

  • submit_answer used the file outside of the block, causing dispose invoked too early. This commit fixed by introduce a disposable stack outside of the block
  • make it more effifient by unzip -p xx.zip name to extract single file only, tather than whole zip. If the file not exists, the unzip returns 11

Summary by CodeRabbit

  • Refactor
    • Enhanced asynchronous operation handling for improved cleanup and background task management. These improvements ensure that processes complete more reliably and efficiently, contributing to a more stable and responsive system experience for end-users.

Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

This pull request modifies the judgeCase function in the Hydrojudge package by introducing an asynchronous cleanup mechanism. A cleanup object is created with a clean method that now calls Symbol.asyncDispose on the result returned from the runQueued operation. Additionally, the previous await using statement for the resource variable has been replaced with a const declaration. There are no changes to the exported or public entities.

Changes

File Change Summary
packages/hydrojudge/.../submit_answer.ts Introduced an async cleanup mechanism in judgeCase: replaced await using with a const declaration for the resource and updated cleanup.clean to call Symbol.asyncDispose on the resource after runQueued.

Sequence Diagram(s)

sequenceDiagram
    participant JC as judgeCase
    participant R as runQueued Resource
    participant Cleanup as Cleanup Object

    JC->>R: Call runQueued()
    R-->>JC: Return resource
    JC->>Cleanup: Set cleanup.clean to call resource[Symbol.asyncDispose]()
    JC->>Cleanup: Invoke cleanup.clean() for cleanup
Loading

Possibly related PRs

Poem

I hopped through the code with a bound so light,
Async cleanup now makes my logic just right.
No more tangled awaits in my burrow so neat,
With Symbol.asyncDispose, everything's complete!
Hopping happily in cleaner code delight! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS  Optional dependencies cannot be installed without production dependencies

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baf8278 and 782ff6f.

📒 Files selected for processing (1)
  • packages/hydrojudge/src/judge/submit_answer.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/hydrojudge/src/judge/submit_answer.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@criyle criyle changed the title judge: fix submission dispose too early judge: fix submission dispose too early & make submit_answer more efficient Mar 14, 2025
@undefined-moe undefined-moe merged commit 4b7de2f into hydro-dev:next Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants