-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
judge: fix submission dispose too early & make submit_answer more efficient #962
Conversation
WalkthroughThis pull request modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant JC as judgeCase
participant R as runQueued Resource
participant Cleanup as Cleanup Object
JC->>R: Call runQueued()
R-->>JC: Return resource
JC->>Cleanup: Set cleanup.clean to call resource[Symbol.asyncDispose]()
JC->>Cleanup: Invoke cleanup.clean() for cleanup
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
submit_answer
used the file outside of the block, causingdispose
invoked too early. This commit fixed by introduce a disposable stack outside of the blockunzip -p xx.zip name
to extract single file only, tather than whole zip. If the file not exists, theunzip
returns11
Summary by CodeRabbit