Update IFCTests.cs

hypar-io · Nov 29, 2023 · 46acce6 · 46acce6
1 parent 639575f
commit 46acce6
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/Elements.Serialization.IFC/test/IFCTests.cs b/Elements.Serialization.IFC/test/IFCTests.cs
@@ -29,17 +29,19 @@ public IfcTests(ITestOutputHelper output)
         // [InlineData("rac_sample", "../../../models/IFC4/rac_advanced_sample_project.ifc")]
         // [InlineData("rme_sample", "../../../models/IFC4/rme_advanced_sample_project.ifc")]
         // [InlineData("rst_sample", "../../../models/IFC4/rst_advanced_sample_project.ifc")]
-        [InlineData("AC-20-Smiley-West-10-Bldg", "../../../models/IFC4/AC-20-Smiley-West-10-Bldg.ifc", 1963, 120, 530, 270, 9, 140, 10, 2)]
+        [InlineData("AC-20-Smiley-West-10-Bldg", "../../../models/IFC4/AC-20-Smiley-West-10-Bldg.ifc", 1919, 120, 530, 270, 170, 140, 10, 11)]
         // TODO: Some walls are extracted incorrectly and intersecting the roof. It happens because
         // IfcBooleanClippingResultParser doesn't handle the boolean clipping operation.
         // In order to fix it surface support is required.
         // The Plane case isn't implemented because some critical information about IfcPlane is
         // missing during it's extraction.
         // TODO: German names are converted incorrectly.
-        // TODO: The entrance door has an incorrect representation. It happens because during
-        // the UpdateRepresentation the default representation of a door is created instead of
-        // the extracted one.
-        [InlineData("AC20-Institute-Var-2", "../../../models/IFC4/AC20-Institute-Var-2.ifc", 1506, 5, 570, 121, 7, 82, 0, 21)]
+
+        // TODO: The representation of the entrance door is placed incorrectly. For some reason
+        // in happens with windows and doors (and maybe some other) representations, created from BREP.
+        // The Element.Transform is correct in this case, so the door should be placed correctly when
+        // the default representation is used.
+        [InlineData("AC20-Institute-Var-2", "../../../models/IFC4/AC20-Institute-Var-2.ifc", 1488, 5, 570, 121, 77, 82, 0, 21)]
         // [InlineData("20160125WestRiverSide Hospital - IFC4-Autodesk_Hospital_Sprinkle", "../../../models/IFC4/20160125WestRiverSide Hospital - IFC4-Autodesk_Hospital_Sprinkle.ifc")]
         public void FromIFC4(string name,
                          string ifcPath,