rename and make properties accessible

[anthonie-kramer]

BACKGROUND:

• Doors needed some properties exposed for functions... This way doors can be adapted depending on context (e.g. wall thickness)

DESCRIPTION:

• Makes properties public so users can define these in their function as needed

TESTING:

• These are being used in the updated Doors and Interior Partitions functions

FUTURE WORK:

• Possibly more refactoring as we make this cleaner

REQUIRED:

• All changes are up to date in CHANGELOG.md.

COMMENTS:

• Any other notes.

---

This change is 

[wynged]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @anthonie-kramer)

---

Elements/test/DoorTest.cs line 17 at r1 (raw file):

            var line = new Line(new Vector3(0, 0, 0), new Vector3(10, 10, 0));
            var wall = new StandardWall(line, 0.1, 3.0);
            var door = new Door(wall.CenterLine, 0.5, 2.0, 2.0, 2 * 0.0254, DoorOpeningSide.LeftHand, DoorOpeningType.SingleSwing);

this value probably wants to be a const like DEFAULT_DOOR_THICKNESS

---

Elements.Serialization.IFC/src/IFCToHypar/Converters/FromIfcDoorConverter.cs line 40 at r1 (raw file):

            var doorWidth = (IfcLengthMeasure)ifcDoor.OverallWidth;
            var doorHeight = (IfcLengthMeasure)ifcDoor.OverallHeight;
            var doorThickness = 2 * 0.0254;

use same const as above.

---

Elements.Serialization.IFC/test/IFCTests.cs line 141 at r1 (raw file):

            var wall2 = new StandardWall(wallLine2, 0.2, 2, name: "Wall2");

            var door1 = new Door(wallLine1, 0.5, 1.5, 2.0, 2 * 0.0254, DoorOpeningSide.LeftHand, DoorOpeningType.DoubleSwing);

maybe also use the const? less important in test.

[anthonie-kramer]

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @wynged)

---

Elements/test/DoorTest.cs line 17 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

this value probably wants to be a const like DEFAULT_DOOR_THICKNESS

Done.

---

Elements.Serialization.IFC/src/IFCToHypar/Converters/FromIfcDoorConverter.cs line 40 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

use same const as above.

Done.

---

Elements.Serialization.IFC/test/IFCTests.cs line 141 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

maybe also use the const? less important in test.

Done.

[wynged]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained