Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdaptiveGrid.Clone #1064

Merged

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Nov 28, 2023

BACKGROUND:

  • There are situation were AdaptiveGrid needs to be changed based on the situation in different ways.
  • Right now all updates should be done on top of each other or grid should be reconstructed from the start.

DESCRIPTION:

  • Added Clone function that performs deep copy of all grid internal data.

TESTING:

  • Added AdaptiveGridClone test.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

@wynged wynged self-requested a review November 29, 2023 01:56
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @DmytroMuravskyi)


Elements/test/AdaptiveGridTests.cs line 1167 at r1 (raw file):

            Assert.True(grid.TryGetVertexIndex((5, -5), out index));
            Assert.False(clone.TryGetVertexIndex((5, 2), out index));

this check seems duplicated with check above?

Copy link
Contributor Author

@DmytroMuravskyi DmytroMuravskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @wynged)


Elements/test/AdaptiveGridTests.cs line 1167 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

this check seems duplicated with check above?

It should be (5; -5) good catch, fixed.

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just udpate b

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update branch and i"ll merge :)

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 0f97b40 into hypar-io:master Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants