Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to set and get snap points #1065

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

anthonie-kramer
Copy link
Contributor

@anthonie-kramer anthonie-kramer commented Nov 29, 2023

BACKGROUND:

  • Snap points are automatically created from representions, which can create too many snap points available for Elements.

DESCRIPTION:

  • Adds Set and Get methods to the ElementRepresentation which checks if a developer has specified their own snap points.

TESTING:

FUTURE WORK:

  • There may also be Explore changes required to handle null or empty lists of snap points... but it seems to work just fine.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@anthonie-kramer anthonie-kramer merged commit 8f7ee25 into master Nov 29, 2023
1 check passed
@anthonie-kramer anthonie-kramer deleted the allow-setting-snap-points-on-representation branch November 29, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants