Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door property and representation update #1067

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Door property and representation update #1067

merged 3 commits into from
Nov 29, 2023

Conversation

anthonie-kramer
Copy link
Contributor

@anthonie-kramer anthonie-kramer commented Nov 29, 2023 •
edited by andrewheumann
Loading

BACKGROUND:

  • Door enums needed descriptioni and attribute to be used correctly in Explore
  • Linework representations were broken up so they aren't a single curve

DESCRIPTION:

  • Adds attributes to door properties so enums are used correctly
  • Door curves are split into multiple representations for cleanliness

TESTING:

FUTURE WORK:

  • Hopefully I don't touch Doors anymore! Keeping these kinds of objects in Elements is painful. :(

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

wynged
wynged approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@anthonie-kramer anthonie-kramer merged commit 27cda66 into master Nov 29, 2023
1 check passed
@anthonie-kramer anthonie-kramer deleted the door-final-final branch November 29, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wynged wynged wynged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonie-kramer @wynged