project line orthogonally onto another

[jamesbradleym]

BACKGROUND:

• Some hy-ccups indicated that while we allowed tolerance within our Walls LOD 200 function, we we're not successfully merging these lines which fell out of tolerance for the merge collinear function

DESCRIPTION:

• Adds a method to orthogonally project a line onto another

TESTING:

• Project line A onto line B and observe line A projected orthogonally onto line B.

FUTURE WORK:

• Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

• All changes are up to date in CHANGELOG.md.

COMMENTS:

• Any other notes.

---

This change is 

[wynged]

Reviewed 3 of 3 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @jamesbradleym)

---

Elements/src/Geometry/Line.cs line 1227 at r1 (raw file):

        /// <summary>
        /// Projects current line orthogonally onto another line

I don't we need to specify orthogonally.

---

Elements/src/Geometry/Line.cs line 1234 at r1 (raw file):

        {
            var lineDirection = line.Direction();
            var normalizedDirection = new Vector3(lineDirection.X, lineDirection.Y, lineDirection.Z);

I think you don't need to do this, Direction is already unit length, and even if not there's a Unitized() method that returns a unit length vector.

---

Elements/src/Geometry/Line.cs line 1236 at r1 (raw file):

            var normalizedDirection = new Vector3(lineDirection.X, lineDirection.Y, lineDirection.Z);

            Vector3 ProjectPoint(Vector3 point, Vector3 lineStart)

I was looking at this thinking it seems generically useful in it's own right, and then realized that I think that the DistanceTo(Ray) method might be doing some similar work? maybe make that method output it's closestPointOnRay that's computed internally and use that?

[wynged]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained