Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation to the ContentConfiguration #73

Merged

Conversation

KaterynaSloboda
Copy link
Contributor

@KaterynaSloboda KaterynaSloboda commented Nov 20, 2023

BACKGROUND:

  • Configurations could not be rotated, so they were not selected unless they clearly fell within the width and length dimensions of the room

DESCRIPTION:

  • This PR adds the ability to rotate the configuration by 90 degrees, if the AllowRotatation field of the configuration is set to "True" (depends on the PR: Allow rotation of the ContentConfigurations Elements#1060). This way, the 90 degree rotated version of the configuration will be checked when trying to select it.

TESTING:

  • To fill the room with furniture, use the "Space Type" function. When filling the rooms, the version of the configuration rotated by 90 degrees should be taken into account

This change is Reviewable

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained, all discussions resolved

@KaterynaSloboda KaterynaSloboda force-pushed the add-rotation-to-ContentConfigurations branch from 22a444c to 033d505 Compare December 7, 2023 19:34
@wynged wynged merged commit d1b524c into hypar-io:master Dec 11, 2023
1 check failed
@KaterynaSloboda KaterynaSloboda deleted the add-rotation-to-ContentConfigurations branch December 11, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants