add space associations for all child elements #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonie-kramer
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Does this mean that furniture is shown when moving a space around in edit mode?
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #75, we added a default behavior to
LayoutFunctionCommonfor associating aSpaceproperty with elements generated for a space. In this PR, we make sure all non-standard spaces also specify this property. This prepares us for future "per-parent override" type relationships for furniture, and also makes pringle smoother, letting all generated elements travel along with the space without having to do a "containment" check.This change is