Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thickness preservation #80

Merged
merged 2 commits into from
Dec 11, 2023
Merged

thickness preservation #80

merged 2 commits into from
Dec 11, 2023

Conversation

anthonie-kramer
Copy link
Contributor

@anthonie-kramer anthonie-kramer commented Dec 7, 2023 •
edited by andrewheumann
Loading

  • Update the Interior Partitions function to preserve thickness when it is modified
  • This was previously being overriden when removing overlapping walls and splitting.
  • I also updated the wall trim / extension to extend the thicker wall first in corners, which I think looks the least weird

Shared workflow here if you want to see it
https://hypar.io/workflows/5fbc7b87-0102-48ee-86f1-140eff24395e

This change is Reviewable

andrewheumann
andrewheumann approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@andrewheumann andrewheumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained, all discussions resolved

@anthonie-kramer anthonie-kramer merged commit b57990a into master Dec 11, 2023
@anthonie-kramer anthonie-kramer deleted the preserve-wall-thickness branch December 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheumann andrewheumann andrewheumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonie-kramer @andrewheumann