Allow open collab spaces to have correct parent #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonie-kramer
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
I have to admit, that I was confused at first that ComponentInstance does not derive from ElementInstance, and its list of Instances is also not required to have ElementInstances. Naming things is hard :)
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Collaboration furniture nestled in among open offices didn't show in pringle, because it didn't have a
Parentspace ID assigned (or it did, but it pointed to the "fake" open collaboration spaces produced by open office.)This PR allows those subsidiary spaces to be given a
Parentid andParentBoundary, which can be used to set the parent information on the furniture.I have published these changes in
testversions of Open Office and Open Collaboration, and tested in pringle (by setting those two functions totest) and verified that the additional furniture now shows up.This change is