feat: show types in Extensions debug output
#773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, very clever! I think this could be nice, but I want to check with a few others, just in case (I guess it could result in more noise, if people didn't want it...) cc @cratelyn @rcoh @LucioFranco @hyperium/triage |
|
I love it. I think we have something similar in the Rust SDK internals for our own property bag types. |
seanmonstar
approved these changes
Jul 14, 2025
cratelyn
reviewed
Jul 14, 2025
There was a problem hiding this comment.
belatedly, i wanted to say that i really appreciate this change. it's a nice quality-of-life improvement to make the contents of request/response extensions legible.
thank you, @crepererum! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.