-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): update publishing workflows to use github.repository_owner #3683
base: main
Are you sure you want to change the base?
ci(github): update publishing workflows to use github.repository_owner #3683
Conversation
a4c827c
to
bd2236c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@petermetz does the username hyperledger-ghci
remains the same? (We are changing the hyperledger
prefix so I think we will need a ticket for that as well once Cacti moves to the new org structure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @petermetz does the username
hyperledger-ghci
remains the same? (We are changing thehyperledger
prefix so I think we will need a ticket for that as well once Cacti moves to the new org structure)
@jagpreetsinghsasan I'm not sure either. Based on the screenshot my guess is that the git username and user email are not actually being used for the authentication with npm at all. So it might be that we can just simply remove them instead modifying them to use the variables. I'm deducing this from the fact that it worked on @adrianbatuto 's fork despite the username being different.
@adrianbatuto I think you can just remove those lines and re-test on your fork and if it can still publish to npm then we are golden.
Sorry for the late response, I just got back from leave. |
Primary Changes ---------------- 1. Updated publishing workflows to use gitHub.repository_owner variable Fixes hyperledger-cacti#3597 Signed-off-by: adrianbatuto <[email protected]>
bd2236c
to
80c32e0
Compare
@petermetz I was able to publish successfully after removing the user email and name from the workflow. |
Primary Changes
Fixes #3597
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.