Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): update publishing workflows to use github.repository_owner #3683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianbatuto
Copy link
Contributor

Primary Changes

  1. Updated publishing workflows to use gitHub.repository_owner variable

Fixes #3597

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@adrianbatuto adrianbatuto force-pushed the adrianbatuto/issue3597 branch from a4c827c to bd2236c Compare December 10, 2024 04:34
@adrianbatuto
Copy link
Contributor Author

adrianbatuto commented Dec 10, 2024

Adding here the screenshots of the published packages after running the workflows.
image
image

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@petermetz does the username hyperledger-ghci remains the same? (We are changing the hyperledger prefix so I think we will need a ticket for that as well once Cacti moves to the new org structure)

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @petermetz does the username hyperledger-ghci remains the same? (We are changing the hyperledger prefix so I think we will need a ticket for that as well once Cacti moves to the new org structure)

@jagpreetsinghsasan I'm not sure either. Based on the screenshot my guess is that the git username and user email are not actually being used for the authentication with npm at all. So it might be that we can just simply remove them instead modifying them to use the variables. I'm deducing this from the fact that it worked on @adrianbatuto 's fork despite the username being different.

@adrianbatuto I think you can just remove those lines and re-test on your fork and if it can still publish to npm then we are golden.

@adrianbatuto
Copy link
Contributor Author

Looks good to me. @petermetz does the username hyperledger-ghci remains the same? (We are changing the hyperledger prefix so I think we will need a ticket for that as well once Cacti moves to the new org structure)

@jagpreetsinghsasan I'm not sure either. Based on the screenshot my guess is that the git username and user email are not actually being used for the authentication with npm at all. So it might be that we can just simply remove them instead modifying them to use the variables. I'm deducing this from the fact that it worked on @adrianbatuto 's fork despite the username being different.

@adrianbatuto I think you can just remove those lines and re-test on your fork and if it can still publish to npm then we are golden.

Sorry for the late response, I just got back from leave.
I will look into this and let you know.

Primary Changes
----------------
1. Updated publishing workflows to use gitHub.repository_owner variable

Fixes hyperledger-cacti#3597

Signed-off-by: adrianbatuto <[email protected]>
@adrianbatuto adrianbatuto force-pushed the adrianbatuto/issue3597 branch from bd2236c to 80c32e0 Compare December 19, 2024 06:01
@adrianbatuto
Copy link
Contributor Author

adrianbatuto commented Dec 19, 2024

@petermetz I was able to publish successfully after removing the user email and name from the workflow.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): update publishing workflows to use github.repository_owner
4 participants