build(plugin-satp-hermes): dist/lib/knex/knexfile.ts not under rootDir #3709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the established patterns we use for building the code (./src/main/typescript/)
This fixed the problem of the bundler not finding the knexfile sources.
import statements instead. This came with the benefit that we no longer require
the linter to be turned off and also that compile time checks are in effect.
In the future if we want to go back to importing the knex files dynamically
we could do so by adding a parameter to the log repository constructor parameter
object which could be holding the path to a knex file to be included at runtime.
(though I would only do this if we have no other choice - by default we should
always thrive to use the compiler and do as much at build time as possible).
Fixes #3708
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.