Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): files needs to migrated from Tape to Jest #3737

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Feb 4, 2025

  1. Fixed logger.test.ts after removing the skip on the test and UUID marker
    now appears in the custom stream output
  2. Migrated test file from tape to jest test
  3. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
    test

Peter's Updates

  1. Removed the test case from the tap inclusion patterns in the CI workflow
    and also in .taprc itself.

Fixes: #1465

Co-authored-by: Peter Somogyvari [email protected]

Signed-off-by: ruzell22 [email protected]
Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 This is great, thank you very much!

@hyperledger-cacti/cacti-maintainers Please review when you get the chance!

Primary Changes
---------------
1. Fixed logger.test.ts after removing the skip on the test and UUID marker
now appears in the custom stream output
2. Migrated test file from tape to jest test
3. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Peter's Updates
---------------

1. Removed the test case from the tap inclusion patterns in the CI workflow
and also in .taprc itself.

Fixes: hyperledger-cacti#1465

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: ruzell22 <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit 8035753 into hyperledger-cacti:main Mar 6, 2025
139 of 144 checks passed
@petermetz petermetz deleted the issue1465new branch March 6, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(logger): Files needs to migrated from Tape to Jest
3 participants