Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix handling error returned from QueryClientStatePair #139

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

siburu
Copy link
Contributor

@siburu siburu commented Apr 18, 2024

This PR also does:

  • Fix some other error handling
  • Delete some unused code
  • Update buf (protobuf) stuffs

siburu added 3 commits April 19, 2024 06:03
Signed-off-by: Masanori Yoshida <[email protected]>
Signed-off-by: Masanori Yoshida <[email protected]>
@siburu siburu requested a review from a team as a code owner April 18, 2024 22:26
@siburu siburu force-pushed the bugfix/provestate-err-handling branch from 86698cd to fe606bb Compare April 18, 2024 23:46
@siburu siburu requested a review from bluele April 18, 2024 23:55
@@ -63,17 +64,17 @@ func parseMsgEventLogs(events []abcitypes.Event, msgIndex uint32) ([]core.MsgEve
return msgEventLogs, nil
}

func msgIndexOf(event abcitypes.Event) (uint32, error) {
func msgIndexOf(event abcitypes.Event) (uint32, bool, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch💯

Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siburu Thanks, LGTM👍

@siburu siburu merged commit 4f3349d into hyperledger-labs:main Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants