Improve Node undefined signer implementation #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A signer returns a Promise so an undefined signer implementation that returns a rejected Promise is more consistent with the typing than one that directly throws an Error. This should be functionally equivalent but better match the expectations of the API. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
undefined-signer
branch
from
9929896 to
1650cf9
Compare
andrew-coleman
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A signer returns a Promise so an undefined signer implementation that returns a rejected Promise is more consistent with the typing than one that directly throws an Error. This should be functionally equivalent but better match the expectations of the API.