Feature/integrate with cc tools #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Closed
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
39d2366
to
a064eb0
Compare
Signed-off-by: osamamagdy <[email protected]>
munapower
requested changes
Oct 11, 2024
mbrandenburger
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @osamamagdy this is pretty cool! Let's shape it a bit more!
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
92e4665
to
1ec09a9
Compare
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
87db6e1
to
ae668f1
Compare
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
f9e9d15
to
ae77fce
Compare
Signed-off-by: Osama Magdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
9eab2e5
to
9c485b8
Compare
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
munapower
requested changes
Nov 22, 2024
munapower
requested changes
Nov 22, 2024
Signed-off-by: osamamagdy <[email protected]>
munapower
approved these changes
Nov 26, 2024
Signed-off-by: osamamagdy <[email protected]>
samuelvenzi
reviewed
Nov 27, 2024
There was a problem hiding this comment.
I think this looks pretty good to me! My only remaining concern is about the readme instructions where sudo is used. As commented, I believe it not necessary for every developer ... and I think it is not good practise to let people run sudo commands when following this tutorial.
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
3053333
to
06e1453
Compare
Co-authored-by: Marcus Brandenburger <[email protected]> Signed-off-by: Osama Magdy <[email protected]>
Co-authored-by: Marcus Brandenburger <[email protected]> Signed-off-by: Osama Magdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
a99d1d0
to
2e80ab2
Compare
mbrandenburger
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a tutorial on how to integrate with cc-tools project, specially using the cc-tools-demo project
Which issue(s) this PR fixes:
Fixes the LFX mentorship project Hyperledger Fabric CC-Tools Support for Fabric Private Chaincode