Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker #78

Closed

Conversation

GuillaumeBourque-QC
Copy link
Contributor

Hello this as not been tested but should be near a working solution.

Since the idlab depot is not updated very often we could host a docker image right in GitHub container registry.

In order to use this workflow we need to add a tag to a release like so:

git tag v2.4.5
git push origin v2.4.5

The resulting container is not public but from my readings, this cli (gh) if you have it can make the container publicly avail,

gh api --method PATCH /user/packages/container/hyperledger/indy-node-monitor/visibility --input '{"visibility":"public"}'

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeBourque-QC
Copy link
Contributor Author

No problem at all using the default action which I was not aware of (I only look at https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-container-registry and some googling).

Do you want to to change the workflow with your proposition ? Since we are working in gitlab internally it may be easier for you to test from your repos, or if time is missing I can try to look at it next week ?

@WadeBarnes
Copy link
Member

No problem at all using the default action which I was not aware of (I only look at https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-container-registry and some googling).

Do you want to to change the workflow with your proposition ? Since we are working in gitlab internally it may be easier for you to test from your repos, or if time is missing I can try to look at it next week ?

You should be able to test any changes you make, easily, on your fork in GitHub.

@GuillaumeBourque-QC
Copy link
Contributor Author

Hello Wade,

I tested some of the provided example but seem more complicated and dont see the value for this repos.

Also from GitHub Action examples that you can see when you create from their template they all use docker build.

image

So I did several test and came up with a working solution based on tags. you can run manually the workflow and provide a tag version or it will build on the latest tag.

Maybe we could start from this ? I will push my code in a few minutes ?

@GuillaumeBourque-QC
Copy link
Contributor Author

I can't get out of this because of 1 commit which is not sign even if I did tried to sing all my commit, it's friday night here, will continue next week...

Maybe I'll close this PR an open a new one for simplicity and to avoid all these comit.

@GuillaumeBourque-QC
Copy link
Contributor Author

Will continue in the new PR #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants