This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Solang q3 #305
Merged
Solang q3 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaheldinsoliman
requested review from
VRamakrishna,
arsulegai,
denyeart,
jimthematrix,
mbrandenburger,
non-fungible-nelson,
petermetz,
swcurran,
tkuhrt and
yacovm
as code owners
petermetz
approved these changes
Sep 25, 2024
tkuhrt
approved these changes
Sep 25, 2024
|
I'm confused as to why there are 10 commits in this pull request. |
swcurran
approved these changes
Oct 3, 2024
It does look like it might be worthwhile to squash/fixup the commits as needed. I usually stay away from asking for this on TOC/TAC pull requests that are just updating docs anyway, but this looks quite interesting indeed. |
jimthematrix
approved these changes
Oct 7, 2024
denyeart
approved these changes
Oct 7, 2024
mbrandenburger
approved these changes
Oct 8, 2024
|
@salaheldinsoliman : If you can rebase this PR, we can get it merged. |
VRamakrishna
approved these changes
Oct 10, 2024
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.