Gdb support for mshv guests #327
Conversation
|
This looks great! I noticed the |
Thanks, I forgot about the documentation. |
There was a problem hiding this comment.
LGTM! It would be good if @syntactically could review as well
| @@ -26,6 +27,7 @@ use event_loop::event_loop_thread; | |||
| use gdbstub::conn::ConnectionExt; | |||
| use gdbstub::stub::GdbStub; | |||
| use gdbstub::target::TargetError; | |||
| pub use hyp_debug::{kvm, mshv, GuestMemoryDebug, GuestVcpuDebug}; | |||
There was a problem hiding this comment.
Yes, it is used in each hypervisor driver.
There was a problem hiding this comment.
Could you use pub(crate) use hyp_debug::{kvm, mshv, GuestMemoryDebug, GuestVcpuDebug}; instead?
- this is done in preparation of accomodating support for other hypervisors which means some of the functionality whould be common. - moving the debug code to a separate file can enable us to group common behavior in traits Signed-off-by: Doru Blânzeanu <[email protected]>
- also add a trait that contains all the needed methods for interacting with a vCPU Signed-off-by: Doru Blânzeanu <[email protected]>
…ity trait Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
… file - add trait to define common behavior to be used by other hypervisors later Signed-off-by: Doru Blânzeanu <[email protected]>
- it can be done using the generic way to add hw breakpoints - also remove the entry point breakpoint after the vCPU stops to avoid hanging there Signed-off-by: Doru Blânzeanu <[email protected]>
- verify the debug registers that report what kind of exception was triggered - in case there is an unknown reason, report it as a SwBp so that the gdb client can inspect what happened Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
- use checked_sub to avoid issues from addresses that could cause underflow Signed-off-by: Doru Blânzeanu <[email protected]>
- change gdb commands in test to be usable with older gdb versions - change Justfile to provide mshv3 feature - change gdb test to invoke cargo test with correct features for mshv Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
This PR address the #220 issue.
Additionally, the first 7 commits refactor the existing guest debugging code and moves code from
kvm.rsto a new file that is to contain the hypervisor specific debugging functionality.