Bring back panic info to abort #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbugs
added
the
kind/refactor
danbugs
requested review from
ludfjig,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
danbugs
force-pushed
the
buffer-outb-output
branch
from
0dc0bbf to
f96c34f
Compare
danbugs
changed the title
ludfjig
reviewed
May 13, 2025
ludfjig
reviewed
May 13, 2025
danbugs
force-pushed
the
buffer-outb-output
branch
5 times, most recently
from
8729e15 to
6dec279
Compare
Removed thread_local buffer and moved buffer to |
danbugs
force-pushed
the
buffer-outb-output
branch
from
ce71264 to
88df03a
Compare
ludfjig
previously requested changes
May 14, 2025
No. &[0, 0xFF] is a single exit. Adding this beforehand, will cause the guest to exit earlier and not get back to do the other outb. |
danbugs
force-pushed
the
buffer-outb-output
branch
from
88df03a to
6f4124a
Compare
HostFunctionDefinitions and GuestErrorData were unused. Signed-off-by: danbugs <[email protected]>
…details git2 uses deep C bindings to libgit2 that might not be available on every target, we should allow disabling logging build details. Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
buffer-outb-output
branch
from
6f4124a to
893108d
Compare
…panic info to abort In hyperlight-dev#474, I removed the guest panic context region. With that, aborting was split into two steps: (1) printing panic info w/ debug_print, and (2) exiting w/ abort and codes. This PR addresses feedback I got in hyperlight-dev#474 to join the operations by buffering string output when aborting. This PR also cleans up our manual chunking logic w/ outb and leverages out32 w/ length prefixing to minimize VM exits. Abort detects it should finishing buffering by a terminator code (0xFF). Edited tests to check for panic message in aborts as they were prior to hyperlight-dev#474 merged. Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
buffer-outb-output
branch
from
893108d to
23dcf47
Compare
simongdavies
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #474, I removed the guest panic context region. With that, aborting was split into two steps:
(1) printing panic info w/ debug_print, and
(2) exiting w/ abort and codes.
This PR addresses feedback I got in #474 to join the operations by buffering string output when aborting.
This PR also cleans up our manual chunking logic w/ outb and leverages out8, out16, and out32 to minimize VM exits. Abort detects it should finishing buffering by a terminator code (0xFF).
Edited tests to check for panic message in aborts as they were prior to #474 merged.
This PR can be reviewed commit by commit. I also made some other minor changes like: