Skip to content

Bring back HostFunctionDefinitions Region #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

danbugs
Copy link
Contributor

@danbugs danbugs commented Jun 11, 2025

This memory region removed because it wasn't used by Hyperlight Core, but it is used for type introspection in Hyperlight Wasm when running Wasm modules, so this PR reverts the work of #453.

@danbugs danbugs added the kind/refactor For PRs that restructure or remove code without adding new functionality. label Jun 11, 2025
@danbugs danbugs force-pushed the revert-pr-453 branch 2 times, most recently from f949a1c to d27a2e5 Compare June 11, 2025 05:22
@danbugs danbugs force-pushed the revert-pr-453 branch 5 times, most recently from eea95ae to db43b0b Compare June 12, 2025 15:45
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works.

danbugs added 2 commits June 12, 2025 16:08
…tFunctionDefinitions memory region"

This reverts commit 1d938f2.

Signed-off-by: danbugs <[email protected]>
@danbugs danbugs merged commit 1c7fc4d into hyperlight-dev:main Jun 12, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants