Remove Allocations from Panic Handler #818
Open
+296
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
adamperlin
force-pushed
the
adamperlin/panic-remove-allocations
branch
from
c83158f to
93e8563
Compare
danbugs
reviewed
Aug 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ludfjig
reviewed
Aug 22, 2025
dblnz
reviewed
Aug 25, 2025
adamperlin
force-pushed
the
adamperlin/panic-remove-allocations
branch
3 times, most recently
from
1b0113c to
576df92
Compare
Signed-off-by: adamperlin <[email protected]>
using a new FixedStringBuf type backed by a static mut array. Adds a test to verify that StackOverflow no longer occurs on OOM panic Signed-off-by: adamperlin <[email protected]>
Add some docstrings Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
…n panic handler to avoid any possible recursive panic Signed-off-by: adamperlin <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Perlin <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Perlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
integration test 2. Resolve clippy errors Signed-off-by: adamperlin <[email protected]>
for panic string formatting Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
Signed-off-by: adamperlin <[email protected]>
adamperlin
force-pushed
the
adamperlin/panic-remove-allocations
branch
from
2f25176 to
d786619
Compare
|
Just a note here, this is currently blocked on fuzzing failures due to the memory leak described in #826; currently attempting to use snapshotting in the host call fuzzer to restore back to a clean memory state on each fuzzing iteration, which I will open a separate PR for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #735. The approach used here is to onboard the
heaplesscrate tohyperlight-guest-binand utilize a static lifetime fixed-sizeheapless::Stringto hold the panic message.