-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aix): add aix directory synchronization support #2115
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for badger-docs canceled.
|
624ddf8
to
21435d9
Compare
AIX doesn't support a proper flock like linux, but it seems to have enough support for process level file locking using fcntl. For hypermodeinc#2035
21435d9
to
ceab022
Compare
Hi, is there something I need to fix in the CL, or is this a CI issue? |
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
This is still useful. Ping. |
@pmur tests are passing now, though I'm concerned about the maintenance cost of this when we don't have an environment to test on–is that something you're able/willing to help with? |
In case it's helpful, I'll point out that you can get some signal from compile-only testing via cross-compilation. For example, |
I can provide some help in a limited capacity. Note, I have been using publicly available resources to implement test this (the aix golang CI instance, and the aix gcc compiler farm instance). I hope @ayappanec might be able to provide more official help. He is part of the IBM team maintaining OSS software on aix. |
@pmur Thanks for tagging me here. |
AIX doesn't support a proper flock like linux, but it seems to have enough support for process level file locking using fcntl.
For #2035
Problem
GOOS=aix does not build. AIX does not support a linux-like flock, and does not export
unix.Flock
.Solution
Create an AIX specific directory-locking implementation using the AIX version of flock.