Fix exception serialization in user deletion #8450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Jan 23, 2024
| @@ -144,8 +144,8 @@ def users_delete(request): | |||
|
|
|||
|
|
|||
| @view_config(context=UserNotFoundError) | |||
| def user_not_found(exc, request): # pragma: no cover | |||
| request.session.flash(Markup(_(exc.message)), "error") | |||
There was a problem hiding this comment.
This is the only non-test code change in the PR.
| @@ -75,19 +76,6 @@ def test_users_index_strips_spaces(models, pyramid_request): | |||
| models.User.get_by_username.assert_called_with(pyramid_request.db, "bob", "foo.org") | |||
|
|
|||
|
|
|||
| @users_index_fixtures | |||
There was a problem hiding this comment.
Merged some tests in this file, they were one-assertion-per-test style which becomes verbose pretty quickly. Done in a separate commit.
| @@ -204,6 +153,13 @@ def test_users_delete_user_not_found_error(user_service, pyramid_request): | |||
| users_delete(pyramid_request) | |||
|
|
|||
|
|
|||
| def test_user_not_found_view(pyramid_request): | |||
There was a problem hiding this comment.
New test for previously un-tested view.
marcospri
force-pushed
the
fix-exception-message
branch
from
cff1e02 to
2ec6058
Compare
seanh
approved these changes
Jan 23, 2024
marcospri
force-pushed
the
fix-exception-message
branch
from
2ec6058 to
a116675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://hypothesis.sentry.io/issues/4905837844/?project=37293&referrer=github-pr-bot
Took the opportunity to refactor some tests around this file.