Use h-testkit #8453
Merged
Use h-testkit #8453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of duplicating test fixtures.
seanh
commented
Jan 23, 2024
| @@ -126,7 +126,7 @@ commands = | |||
| functests: sh bin/create-testdb h_functests | |||
| {tests,functests}: python3 -m h.scripts.init_db --delete --create | |||
| tests: python -m pytest --cov --cov-report= --cov-fail-under=0 --numprocesses logical --dist loadgroup {posargs:tests/unit/} | |||
| functests: pytest {posargs:tests/functional/} | |||
| functests: python -m pytest {posargs:tests/functional/} | |||
There was a problem hiding this comment.
This was necessary to fix an h-testkit import error. This is the more correct form of the command anyway (and what the cookiecutter does)
marcospri
reviewed
Jan 23, 2024
| When h is upgraded to SQLAlchemy 2 we can upgrade this fixture to use the | ||
| newer, SQLAlchemy 2 version of the technique: | ||
| https://docs.sqlalchemy.org/en/20/orm/session_transaction.html#joining-a-session-into-an-external-transaction-such-as-for-test-suites | ||
| When h is upgraded to SQLAlchemy 2 this fixture can be removed and it can |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating test fixtures.
Depends on hypothesis/cookiecutters#165.
I might want to take a closer look at this one because h contains its own code for integrating factoryboy and sqlalchemy in a different way and it should be letting h-testkit do that now. Might want to straighten that out.