-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy unpaginated list-group-members API #9183
base: main
Are you sure you want to change the base?
Conversation
@@ -116,7 +22,6 @@ def test_it_returns_list_of_members_for_restricted_group_without_auth( | |||
|
|||
res = app.get( | |||
"/api/groups/{pubid}/members".format(pubid=group.pubid), | |||
params={"page[offset]": 1, "page[limit]": 2}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the pagination query params from these functests, so they're now testing that the default behaviour of the API (without these query params) is paginated. Added a separate test for pagination below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming that removing the legacy API can be done without causing significant disruption.
ac6c469
to
0bf36c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- docs/_extra/api-reference/hypothesis-v1.yaml: Language not supported
- docs/_extra/api-reference/hypothesis-v2.yaml: Language not supported
Comments skipped due to low confidence (1)
tests/functional/api/groups/members_test.py:47
- The use of
list(enumerate(group.memberships))
is unnecessary. It should beenumerate(group.memberships)
.
for second, membership in list(enumerate(group.memberships))
117e029
to
6b20525
Compare
0bf36c2
to
c8e062e
Compare
As far as I'm concerned this PR is ready to go as soon as we're satisfied that no one is still using the legacy API |
Before merging this we should: